Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade dependency versions #733

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Upgrade dependency versions #733

wants to merge 3 commits into from

Conversation

asha15
Copy link
Contributor

@asha15 asha15 commented Nov 6, 2024 •
edited
Loading

Purpose

$subject

Upgrade carbon identity framework from 7.5.106 to 7.5.117.
Upgrade identity-oauth-addons from 2.5.17 to 2.5.28.

Related issue: wso2/product-is#21200

Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email [email protected] to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to [email protected] and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

  • Unit tests

    Code coverage information

  • Integration tests

    Details about the test cases and coverage

Security checks

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

@asha15 asha15 changed the title Upgrade identity-oauth-addons version Upgrade dependency versions Nov 6, 2024
@asha15
Copy link
Contributor Author

asha15 commented Nov 6, 2024 •
edited
Loading

We have encountered the following error during the framework version upgrade:

Error:  Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.10.1:compile (default-compile) on project org.wso2.carbon.identity.api.server.action.management.v1: Compilation failure
Error:  /home/runner/work/identity-api-server/identity-api-server/components/org.wso2.carbon.identity.api.server.action.management/org.wso2.carbon.identity.api.server.action.management.v1/src/main/java/org/wso2/carbon/identity/api/server/action/management/v1/core/ServerActionManagementService.java:[389,72] cannot find symbol
Error:    symbol:   variable NOT_IMPLEMENTED
Error:    location: class javax.ws.rs.core.Response.Status

With the following change [1] we have added org.wso2.carbon.identity.central.log.mgt artifact and which is using a old javax.ws.rs during the runtime. Due to that the build has been failing. To fix it we have excluded that dependency [2].

image(1)

[1] https://github.com/wso2/carbon-identity-framework/pull/6088/files#diff-7ce92ef74a91a36f6bbfe09ffd69656c5619e23e647bc21f88596851d2ae53f7R58
[2] https://github.com/wso2/identity-api-server/pull/733/files#diff-3a051ad31a81f07fc339c5499ecf4c34c3b81039287c8b20c603905d0db918a1R39

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11702362749

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11702362749
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Nov 6, 2024
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11702362749

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asha15 @jenkins-is-staging